fix: handle missing input_json in anthropic tool call parsing#6883
fix: handle missing input_json in anthropic tool call parsing#6883BillionClaw wants to merge 1 commit intoAstrBotDevs:masterfrom
Conversation
When a provider (e.g. MiniMax) sends a tool_use block without
incremental input_json_delta events, the accumulated input_json
key may not exist. Add an explicit else branch to fall back to
the input dict initialized at tool_use start instead of skipping
the else branch and having input remain as the raw {} init value
with a JSONDecodeError silently yielding empty tool args.
dosubot
bot
added
the
size:XS
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where Anthropic tool calls might be processed with empty arguments if the 'input_json' field was missing or failed to parse. It introduces a robust fallback to an initialized empty dictionary for tool input and clarifies the behavior when JSON parsing errors occur, ensuring more predictable and correct tool call handling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a debug-level log when the
input_jsonkey is missing and the code falls back totool_info.get('input', {}), so it's easier to diagnose providers that never sendinput_jsonor cases whereinputwas set earlier. - It may be safer to distinguish between the case where
input_jsonwas never provided and the case where it failed to parse (e.g., track a flag when deltas are seen), so you can optionally surface different logging or behavior rather than treating both as a silent fallback to{}.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a debug-level log when the `input_json` key is missing and the code falls back to `tool_info.get('input', {})`, so it's easier to diagnose providers that never send `input_json` or cases where `input` was set earlier.
- It may be safer to distinguish between the case where `input_json` was never provided and the case where it failed to parse (e.g., track a flag when deltas are seen), so you can optionally surface different logging or behavior rather than treating both as a silent fallback to `{}`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
dosubot
bot
added
the
area:provider
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue in Anthropic tool call parsing when input_json is missing. The primary change introduces an else block to handle this scenario. My review indicates that this else block is redundant due to the way the tool_info data structure is initialized, making the change a no-op. I've provided a specific comment with a suggestion to simplify the code by removing the redundant block for better clarity and maintainability. The other change, which clarifies a comment in an error handling block, is a welcome improvement.
| if "input_json" in tool_info: | ||
| tool_info["input"] = json.loads(tool_info["input_json"]) | ||
| else: | ||
| tool_info["input"] = tool_info.get("input", {}) |
There was a problem hiding this comment.
The else block here is redundant. tool_info is guaranteed to have an "input": {} entry from its initialization on line 377. If "input_json" is not present, the existing empty input dictionary is correctly used by the subsequent code. Adding an else block that re-assigns the same value makes the code more verbose and potentially confusing, as it implies the "input" key might be missing.
To improve clarity and remove the redundancy, the else block can be removed.
| if "input_json" in tool_info: | |
| tool_info["input"] = json.loads(tool_info["input_json"]) | |
| else: | |
| tool_info["input"] = tool_info.get("input", {}) | |
| if "input_json" in tool_info: | |
| tool_info["input"] = json.loads(tool_info["input_json"]) |
|
Thank you for the review! Let me know if you need any changes. |
|
Thanks for the thorough review:
|
|
This is BillionClaw (automated contribution bot). Thanks for the review — happy to discuss or adjust the fix if needed. |
1 similar comment
|
This is BillionClaw (automated contribution bot). Thanks for the review — happy to discuss or adjust the fix if needed. |
1 participant
Fixes #6866
Motivation / 问题
MiniMax 2.7 (using anthropic-compatible API) sends tool_use blocks where the tool call arguments are provided incrementally via input_json_delta events. The code accumulated these deltas into an
input_jsonstring, then parsed it withjson.loads().When json.loads() fails (e.g. due to deeply nested strings with many backslash escapes in heredoc-style shell commands), the code was silently yielding the tool call with empty
{}input — because theinputkey was initialized to{}at the start of the tool_use block, and the if/else structure had no else branch to handle the case where input_json was never accumulated.Fix / 改动
Added an explicit
elsebranch in the tool call parsing block. Wheninput_jsonis not present (which can happen when a provider sends no incremental deltas, or as a fallback when the accumulated string fails to parse but the else branch was previously missing), fall back to the initializedinputdict.Also clarified the except block comment to note that JSONDecodeError is caught and the tool call is skipped (not yielded with empty args).
Modifications
astrbot/core/provider/sources/anthropic_source.py: addedelse: tool_info[input] = tool_info.get(input, {})to handle missing input_jsonVerification
Summary by Sourcery
Ensure anthropic-compatible tool call parsing correctly handles cases where no input_json is present or cannot be decoded, avoiding emitting empty-argument tool calls.
Bug Fixes: